• dohpaz42@lemmy.world
    link
    fedilink
    English
    arrow-up
    66
    ·
    2 days ago

    Git commits with message saying “pushing changes” and there are over 50 files with unrelated code in it.

    • Black616Angel@discuss.tchncs.de
      link
      fedilink
      arrow-up
      3
      ·
      23 hours ago

      In the past I had commit messages with change numbers from a system, that was no longer in use.

      So the commit just said “CH-12345“. It is the kind of annoying, where you can’t even really be mad at someone.

      • dohpaz42@lemmy.world
        link
        fedilink
        English
        arrow-up
        2
        ·
        22 hours ago

        I put my ticket numbers in my tickets, but i also try to describe the change too (e.g. “Fix bug where xyz happens due to zyx action”). Also, atomic commits: commit only related changes.

        Yes, it takes longer to commit large changes, BUT you can easily merge the commits, and rollback only what needs to be rolled back.

      • pinball_wizard@lemmy.zip
        link
        fedilink
        arrow-up
        23
        ·
        edit-2
        2 days ago

        “Fix for critical issue.”

        Followed by an equally large set of files in a commit with just the message:

        “Fixup”

        And then the actual fix turns out to be mixed in with “Start sprint 57 - AutoConfiguration Refactor” which follows “Fixup”